add eth_maxPriorityFeePerGas to http-retry middleware whitelist #3090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
force-pushed
the
add-maxpriofee-to-http-retry-middleware
branch
2 times, most recently
from
4e33704
to
27f15cd
Compare
pacrob
force-pushed
the
add-maxpriofee-to-http-retry-middleware
branch
from
a5ae7bd
to
4c484ec
Compare
|
lgtm 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
eth_maxPriorityFeePerGaswas requested to be added to thehttp_retry_request_middlewarewhitelist.Closes #2993
How was it fixed?
Added. I looked into whether this would interfere with
eth_maxPriorityFeePerGasfalling back toeth_feeHistory, but that fallback depends on getting a completed HTTP request through first.Found a typo in tests too.
Todo:
Cute Animal Picture